[BC Break] Add support for Symfony 6 (from @Slamdunk) #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asgrim
commented
Feb 23, 2022
Closed
… guarantee against upstream BC breaks when supporting multiple Symfony major versions
Codecov Report
@@ Coverage Diff @@
## 6.2.x #418 +/- ##
============================================
- Coverage 39.28% 37.64% -1.64%
Complexity 283 283
============================================
Files 27 27
Lines 919 842 -77
============================================
- Hits 361 317 -44
+ Misses 558 525 -33
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
asgrim
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #416 #413
The isolated BC breaks in this PR are as follows:
These BC breaks are necessary to prevent upstream Symfony BC breaks leaking into our own API. I did NOT mark these classes as final (although ideally they should be, perhaps we can do that in a future release), but this means we will no longer support BC in any of these classes. Downstream consumers should not extend these
@internalclasses any more, and will receive an error if they are extending them in turn and using Roave/BackwardsCompatibilityCheck.